Replace global loggers with local loggers in tlscommon package#334
Merged
khushijain21 merged 11 commits intoelastic:mainfrom Aug 4, 2025
Merged
Replace global loggers with local loggers in tlscommon package#334khushijain21 merged 11 commits intoelastic:mainfrom
tlscommon package#334khushijain21 merged 11 commits intoelastic:mainfrom
Conversation
khushijain21
requested review from
VihasMakwana and
andrzej-stencel
and removed request for
a team
khushijain21
changed the title
khushijain21
changed the title
tlscommon package
kruskall
reviewed
Aug 1, 2025
mauri870
previously approved these changes
Aug 1, 2025
Member
mauri870
left a comment
mauri870
left a comment
There was a problem hiding this comment.
LGTM. Please make sure to address Joseph's feedback first.
AndersonQ
reviewed
Aug 1, 2025
Collaborator
💚 Build Succeeded
History
|
AndersonQ
approved these changes
Aug 1, 2025
6 tasks
This was referenced Aug 7, 2025
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, logs from
tlscommonpackage printca_trusted_fingerprintprovided by user and also those that are available on the server. This could be a sensitive information and should not be shipped.Why is it important?
Checklist
Related issues
Part of https://github.com/elastic/ingest-dev/issues/5251